Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: getsentry/sentry-javascript
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 6.19.3
Choose a base ref
...
head repository: getsentry/sentry-javascript
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 6.19.4
Choose a head ref
  • 15 commits
  • 68 files changed
  • 6 contributors

Commits on Mar 30, 2022

  1. Merge branch 'release/6.19.3'

    getsentry-bot committed Mar 30, 2022
    Copy the full SHA
    68fa16c View commit details

  2. ref(browser): Remove dup isDebugBuild (#4826)

    @AbhiPrasad
    AbhiPrasad authored Mar 30, 2022
    Copy the full SHA
    8d9c2bf View commit details

Commits on Mar 31, 2022

  1. ref(build): Add build/types to tarballs and adjust types entry po… 

    …ints (#4824)

* All tarballs now include the `build/types` directory. All `.npmignore`s were adjusted to include this directory.
* The `types` entry point in all `package.json`s are now adjusted to the new types directory

Proper bugfix for 6.19.0 regression:
With PR #4724, we introduced separate building of type declaration files which would be written to `<sdk>/build/types`. Furthermore, we adjusted the `types` entry point in the `package.json`s to this new directory. To avoid a breaking change, we kept type declarations in `dist` and `esm`. However, a bug in this PR caused a small regression in most of our SDKs: The new types directory was not included in most of our SDK tarballs. Subsequently, we released a hot fix via #4745 which simply reset the entry points back to their previous path (`dist/index.d.ts`) in all SDKs. 

Additional adjustments w.r.t. creating tarballs to improve consistency:
* Browser: Adjusted `postbuild.sh` to copy `.npmignore` to `./build`
* Gatsby: Use `.npmignore` instead of `files` property in `package.json`
* Utils: Changed `.npmignore` to be more similar to our other packages
* WASM: Changed `.npmignore` to be more similar to our other packages
* Next.js: Added `.npmignore`
    @Lms24
    Lms24 authored Mar 31, 2022
    Copy the full SHA
    faaacb8 View commit details

  2. feat(react): Add React 18 as peer dep (#4819) 

    - Update peer dependency of `@sentry/react` to include React 18'
- Update peer dependency of `@sentry/gatsby` to include React 18
- Upgrade to `@testing-library/react` v13
- Bump dev deps for React 18
- Remove unused `react-test-renderer` dep
- Update tests to use `act()`: https://reactjs.org/docs/test-utils.html#act
    @AbhiPrasad
    AbhiPrasad authored Mar 31, 2022
    Copy the full SHA
    db661b4 View commit details

  3. test(node): Add basic integration tests for Express. (#4817)

    @onurtemizkan
    onurtemizkan authored Mar 31, 2022
    Copy the full SHA
    2934a73 View commit details

  4. test(node): Add integration tests for aggregated sessions. (#4832)

    @onurtemizkan
    onurtemizkan authored Mar 31, 2022
    Copy the full SHA
    e134014 View commit details

  5. ref(dev): Run linter on scripts (#4834) 

    Because SDK developers running Windows [can't run our bash scripts[1], we recently decided to move to using TypeScript instead. To make this easier, this extends the domain of our `eslint` and `prettier` checks to include all `scripts` folders. It also fixes a few linting errors which doing so brought to light.

[1] #4720
    @lobsterkatie
    lobsterkatie authored Mar 31, 2022
    Copy the full SHA
    5542518 View commit details

  6. fix(build): Ensure full stacktraces when running rollup (#4833) 

    By default, node [cuts stacktraces down to the final 10 frames[1]. Sometimes, though, the stuff you're interested in is below that. This removes the cap for errors generated when running `rollup` (which turned out to be necessary to diagnose a problem encountered during work on the new build process).

[1] https://nodejs.org/api/errors.html#errorstacktracelimit
    @lobsterkatie
    lobsterkatie authored Mar 31, 2022
    Copy the full SHA
    827fcc8 View commit details

Commits on Apr 1, 2022

  1. feat(nextjs): Add React 18 as a peer dep (#4831)

    @AbhiPrasad
    AbhiPrasad authored Apr 1, 2022
    Copy the full SHA
    4793df5 View commit details

  2. ref(build): Stop building Vue CDN bundles by default (#4839) 

    Vue are not uploaded as build artifacts or published to our CDN. Therefore it is not necessary to build them by default (i.e. every time when when running yarn build).

remove bundle creation from the yarn build(:watch) scripts so that they are not built anymore by default. It is still possible to build them by explicitly by running yarn build:bundle(:watch).
    @Lms24
    Lms24 authored Apr 1, 2022
    Copy the full SHA
    43e861d View commit details

Commits on Apr 4, 2022

  1. meta: Update CHANGELOG for 6.19.4 (#4830)

    @AbhiPrasad
    AbhiPrasad authored Apr 4, 2022
    Copy the full SHA
    589bbb3 View commit details

  2. fix(build): Find release branches correctly (#4844) 

    Use `refs/heads/release/` instead of `release` when comparing against `github.ref` to see if size-check should be run.

Needed to unblock next release.
    @AbhiPrasad
    AbhiPrasad authored Apr 4, 2022
    Copy the full SHA
    031bebd View commit details

  3. chore(dev): Unlinkify changelog (#4846) 

    GH now automatically linkifies PR numbers in changelogs, so we don't have to do it ourselves. This removes the manual links from the changelog and the linkifying step from the changelog instructions.
    @lobsterkatie
    lobsterkatie authored Apr 4, 2022
    Copy the full SHA
    66509fd View commit details

  4. fix(build): Raise time limit for build to 20 minutes (#4847) 

    All of the changes happening to the build process (and all of the new bundles we're producing) mean that sometimes the build step is failing because it times out. While in the long run we should fix the build to be faster, in the short run, this ups the time limit, so at least CI won't error out unnecessarily.
    @lobsterkatie
    lobsterkatie authored Apr 4, 2022
    Copy the full SHA
    5f35839 View commit details

  5. release: 6.19.4

    @getsentry-bot
    getsentry-bot committed Apr 4, 2022
    Copy the full SHA
    261f2e4 View commit details
Showing with 1,347 additions and 955 deletions.
  1. +1 −10 .eslintrc.js
  2. +2 −2 .github/workflows/build.yml
  3. +635 −628 CHANGELOG.md
  4. +2 −3 CONTRIBUTING.md
  5. +1 −1 lerna.json
  6. +1 −1 packages/angular/.npmignore
  7. +7 −7 packages/angular/package.json
  8. +9 −2 packages/browser/.npmignore
  9. +7 −7 packages/browser/package.json
  10. +3 −0 packages/browser/scripts/checkbrowsers.js
  11. +1 −1 packages/browser/src/transports/base.ts
  12. +1 −1 packages/core/.npmignore
  13. +8 −8 packages/core/package.json
  14. +1 −1 packages/core/src/version.ts
  15. +5 −5 packages/ember/package.json
  16. +3 −3 packages/eslint-config-sdk/package.json
  17. +1 −1 packages/eslint-plugin-sdk/package.json
  18. +6 −0 packages/gatsby/.npmignore
  19. +10 −16 packages/gatsby/package.json
  20. +1 −1 packages/hub/.npmignore
  21. +6 −6 packages/hub/package.json
  22. +1 −1 packages/integration-tests/package.json
  23. +0 −1 packages/integrations/.npmignore
  24. +6 −6 packages/integrations/package.json
  25. +1 −1 packages/minimal/.npmignore
  26. +6 −6 packages/minimal/package.json
  27. +4 −0 packages/nextjs/.npmignore
  28. +13 −13 packages/nextjs/package.json
  29. +2 −1 packages/node-integration-tests/package.json
  30. +19 −0 packages/node-integration-tests/suites/express/handle-error/server.ts
  31. +23 −0 packages/node-integration-tests/suites/express/handle-error/test.ts
  32. +30 −0 packages/node-integration-tests/suites/express/sentry-trace/server.ts
  33. +22 −0 packages/node-integration-tests/suites/express/sentry-trace/trace-header-assign/test.ts
  34. +20 −0 packages/node-integration-tests/suites/express/sentry-trace/trace-header-out/test.ts
  35. +26 −0 packages/node-integration-tests/suites/express/tracing/server.ts
  36. +29 −0 packages/node-integration-tests/suites/express/tracing/test.ts
  37. +36 −0 packages/node-integration-tests/suites/sessions/crashed-session-aggregate/test.ts
  38. +37 −0 packages/node-integration-tests/suites/sessions/errored-session-aggregate/test.ts
  39. +35 −0 packages/node-integration-tests/suites/sessions/exited-session-aggregate/test.ts
  40. +60 −0 packages/node-integration-tests/suites/sessions/server.ts
  41. +38 −2 packages/node-integration-tests/utils/index.ts
  42. +1 −1 packages/node/.npmignore
  43. +8 −8 packages/node/package.json
  44. +1 −1 packages/react/.npmignore
  45. +13 −14 packages/react/package.json
  46. +2 −1 packages/react/test/errorboundary.test.tsx
  47. +10 −4 packages/react/test/reactrouterv3.test.tsx
  48. +20 −12 packages/react/test/reactrouterv4.test.tsx
  49. +22 −13 packages/react/test/reactrouterv5.test.tsx
  50. +1 −1 packages/serverless/.npmignore
  51. +9 −9 packages/serverless/package.json
  52. +1 −1 packages/serverless/scripts/build-awslambda-layer.js
  53. +0 −1 packages/tracing/.npmignore
  54. +9 −9 packages/tracing/package.json
  55. +1 −1 packages/types/.npmignore
  56. +4 −4 packages/types/package.json
  57. +0 −1 packages/typescript/.npmignore
  58. +1 −1 packages/typescript/package.json
  59. +2 −4 packages/utils/.npmignore
  60. +5 −5 packages/utils/package.json
  61. +1 −2 packages/vue/.npmignore
  62. +11 −11 packages/vue/package.json
  63. +2 −4 packages/wasm/.npmignore
  64. +6 −6 packages/wasm/package.json
  65. +2 −0 rollup.config.js
  66. +2 −1 scripts/postbuild.sh
  67. +4 −4 scripts/test.ts
  68. +90 −101 yarn.lock
11 changes: 1 addition & 10 deletions .eslintrc.js
View file
Original file line number Diff line number Diff line change
@@ -10,16 +10,7 @@ module.exports = {
ecmaVersion: 2018,
},
extends: ['@sentry-internal/sdk'],
ignorePatterns: [
'coverage/**',
'build/**',
'dist/**',
'esm/**',
'examples/**',
'scripts/**',
'test/manual/**',
'types/**',
],
ignorePatterns: ['coverage/**', 'build/**', 'dist/**', 'esm/**', 'examples/**', 'test/manual/**', 'types/**'],
overrides: [
{
files: ['*.ts', '*.tsx', '*.d.ts'],
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
View file
Original file line number Diff line number Diff line change
@@ -62,7 +62,7 @@ jobs:
name: Build
needs: job_install_deps
runs-on: ubuntu-latest
timeout-minutes: 15
timeout-minutes: 20
steps:
- name: Check out current commit (${{ env.HEAD_COMMIT }})
uses: actions/checkout@v2
@@ -124,7 +124,7 @@ jobs:
- name: Check bundle sizes
uses: getsentry/size-limit-action@v4
# Don't run size check on release branches - at that point, we're already committed
if: ${{ !startsWith(github.ref, 'release') }}
if: ${{ !startsWith(github.ref, 'refs/heads/release/') }}
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
skip_step: build
Loading