-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Comparing changes
Open a pull request
base repository: getsentry/sentry-javascript
base: 8.14.0
head repository: getsentry/sentry-javascript
compare: 8.15.0
Commits on Jul 4, 2024
-
test: Fix e2e test race condition by buffering events (#12739)
Co-authored-by: Francesco Novy <francesco.novy@sentry.io>
Configuration menu - View commit details
-
Copy full SHA for 993acd4 - Browse repository at this point
Copy the full SHA 993acd4View commit details -
test(remix): Update remix E2E tests to avoid sending to Sentry (#12750)
Configuration menu - View commit details
-
Copy full SHA for 77ce28a - Browse repository at this point
Copy the full SHA 77ce28aView commit details -
getsentry-bot committed
Jul 4, 2024 Configuration menu - View commit details
-
Copy full SHA for 0ab48f0 - Browse repository at this point
Copy the full SHA 0ab48f0View commit details -
Merge pull request #12753 from getsentry/master
[Gitflow] Merge master into develop
Configuration menu - View commit details
-
Copy full SHA for ddb539c - Browse repository at this point
Copy the full SHA ddb539cView commit details -
feat(core): allow unregistering callback through
on
(#11710)This commit updates the return signature of the client's `on` function to be a void function, which, when executed, unregisters a callback. This adjustment is necessary for managing instances where objects are created and destroyed, ensuring that callbacks are properly unregistered to prevent self-referencing in callback closures and facilitate proper garbage collection. Typically, changing a type from `void` to `() => void` (or `VoidFunction`) shouldn't be considered a breaking change because `void` signifies the absence of a return value, implying that the return value of the `on` function should never be used by consumers. Opting for the `on` approach, which returns a cleanup function, "seems" simpler because having another function called `off` requires saving the callback reference for later removal. With our pattern, we encapsulate both the registration and removal of event listeners within a single function call. --------- Co-authored-by: Francesco Novy <francesco.novy@sentry.io>
Configuration menu - View commit details
-
Copy full SHA for 506e6ca - Browse repository at this point
Copy the full SHA 506e6caView commit details -
fix(tracing): Report dropped spans for transactions (#12751)
We already report a client report for dropped standalone spans. However, so far we did not report any for spans dropped for transactions. This PR also emits a client report when `beforeSendSpan` is used to filter a span of a transaction, as well as when the whole transaction is dropped in `beforeSendTransaction`. For now, we _do not_ emit this if users manually drop single spans in e.g. `beforeSendTransaction`, which I'd say is OK for now. Closes #12727
Configuration menu - View commit details
-
Copy full SHA for ef7e5b6 - Browse repository at this point
Copy the full SHA ef7e5b6View commit details -
test(ember): Update ember tests to use E2E structure (#11827)
This gets rid of the Ember canary tests that are always failing, probably due to ember-try (which we use there) not playing nicely with the monorepo etc. Instead, this now uses the proper E2E setup. I added two tests, for classic ember and modern embroider-based ember. While doing this I also noticed two bugs I fixed along the way :O This also removed the ember canary tests, IMHO the e2e tests are good enough for us there now.
Configuration menu - View commit details
-
Copy full SHA for dc2659c - Browse repository at this point
Copy the full SHA dc2659cView commit details -
test(e2e): Do not require DSN to run E2E tests (#12743)
First, this means it is easier to run this locally. Secondly, we do not even need to send data to Sentry anymore, so we can adjust the proxy server to stop doing this. Lastly, this means that we can also safely run E2E tests for external contributors. Closes #11910
Configuration menu - View commit details
-
Copy full SHA for 8c0631a - Browse repository at this point
Copy the full SHA 8c0631aView commit details -
fix(hapi): Specify error channel to filter boom errors (#12725)
If errors are handled with Boom inside `onPreResponse`, the error should not be reported to Sentry. fixes #12702
Configuration menu - View commit details
-
Copy full SHA for 4018f80 - Browse repository at this point
Copy the full SHA 4018f80View commit details -
ref(scope): Delete unused public
getStack()
(#12737)`getStack()` is a leftover from the Hub API and was removed with v8. The method does not need to be public anymore and therefore deleted.
Configuration menu - View commit details
-
Copy full SHA for e0adb41 - Browse repository at this point
Copy the full SHA e0adb41View commit details -
Configuration menu - View commit details
-
Copy full SHA for f8f3c98 - Browse repository at this point
Copy the full SHA f8f3c98View commit details -
Configuration menu - View commit details
-
Copy full SHA for 41d946e - Browse repository at this point
Copy the full SHA 41d946eView commit details -
feat(otel): Export & use
spanTimeInputToSeconds
for otel span expor……ter (#12699) Adds support for cases where the time from OTEL is just a number in milliseconds instead of tuples.
Configuration menu - View commit details
-
Copy full SHA for b4d6469 - Browse repository at this point
Copy the full SHA b4d6469View commit details -
ci: Fix external contributor workflow (#12755)
This failed (again) here: https://github.com/getsentry/sentry-javascript/actions/runs/9791997167/job/27036907594 Hopefully this fixes it...
Configuration menu - View commit details
-
Copy full SHA for eedd7c0 - Browse repository at this point
Copy the full SHA eedd7c0View commit details
Commits on Jul 5, 2024
-
fix(deno): Publish from build directory (#12773)
In #12700 I adjusted the prepack script to bring back the build directory, but I forgot to adjust `npm pack X` to make sure we pack the tarball from the `build` directory. This patch fixes that.
Configuration menu - View commit details
-
Copy full SHA for 0bad43b - Browse repository at this point
Copy the full SHA 0bad43bView commit details -
build: Ensure we use pnpm 9.4.0 everywhere on CI (#12772)
Just to align stuff properly everywhere!
Configuration menu - View commit details
-
Copy full SHA for 0951036 - Browse repository at this point
Copy the full SHA 0951036View commit details -
fix(core): Pass origin as referrer for
lazyLoadIntegration
(#12766)In our case the referrer is not passed to the feedback script and thus results in a 403 (because we set allowed domains in our project settings). Consequently also the modal doesn't open and it's a bit disappointing for us since we would like to use the feature.
Configuration menu - View commit details
-
Copy full SHA for 1845bf4 - Browse repository at this point
Copy the full SHA 1845bf4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 69b6531 - Browse repository at this point
Copy the full SHA 69b6531View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1af7d0a - Browse repository at this point
Copy the full SHA 1af7d0aView commit details -
Merge pull request #12777 from getsentry/prepare-release/8.15.0
meta(changelog): Update changelog for 8.15.0
Configuration menu - View commit details
-
Copy full SHA for 7c15dfa - Browse repository at this point
Copy the full SHA 7c15dfaView commit details -
Configuration menu - View commit details
-
Copy full SHA for b1e0598 - Browse repository at this point
Copy the full SHA b1e0598View commit details
There are no files selected for viewing
This file was deleted.