Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(aws-lambda/v7): Turn off lambda layer publishing #11875

Merged
merged 2 commits into from May 3, 2024

Conversation

lforst
Copy link
Member

@lforst lforst commented May 2, 2024

We want to stop publishing lambda layers for v7, since lambda layer versioning is linear (a number is incremented), and communitcating which layer version corresponds to which SDK version would be impossible.

Also this lets us use very simple logic in Sentry to determine whether we should include @sentry/serverless or @sentry/aws-lambda within the layer.

Copy link
Contributor

github-actions bot commented May 2, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 80.81 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 71.75 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 76 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 65.37 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 35.63 KB (+0.03% 🔺)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 35.51 KB (+0.02% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.6 KB (+0.02% 🔺)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.61 KB (+0.02% 🔺)
@sentry/browser - Webpack (gzipped) 22.78 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 79.01 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 70.35 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 36.03 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 25.28 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 221.43 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 109.03 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 75.81 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 39.3 KB (+0.01% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 72.25 KB (+0.01% 🔺)
@sentry/react - Webpack (gzipped) 22.81 KB (+0.04% 🔺)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 90.01 KB (+0.01% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 54.14 KB (+0.02% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.34 KB (0%)

@lforst lforst requested review from mydea, s1gr1d and Lms24 May 2, 2024 15:11
@lforst lforst merged commit 0ee4235 into v7 May 3, 2024
103 checks passed
@lforst lforst deleted the lforst-turn-off-lambda-layer-publishing branch May 3, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants