Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react/v7): Fix react router v4/v5 span names #11940

Merged
merged 1 commit into from May 7, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented May 7, 2024

Turns out we were not correctly setting parametrized route names for react router v4/v5 馃槵

Backport of #11855

Fixes #11938

Turns out we were not correctly setting parametrized route names for
react router v4/v5 馃槵
@mydea mydea self-assigned this May 7, 2024
@lforst lforst changed the title fix(react/v7): Fix react router v4/v5 instrumentation fix(react/v7): Fix react router v4/v5 parameterization May 7, 2024
@lforst lforst changed the title fix(react/v7): Fix react router v4/v5 parameterization fix(react/v7): Fix react router v4/v5 span names May 7, 2024
@lforst lforst enabled auto-merge (squash) May 7, 2024 14:55
Copy link
Contributor

github-actions bot commented May 7, 2024

size-limit report 馃摝

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 80.82 KB (+0.02% 馃敽)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 71.76 KB (+0.02% 馃敽)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 76.01 KB (+0.02% 馃敽)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 65.38 KB (+0.02% 馃敽)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 35.64 KB (+0.05% 馃敽)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 35.53 KB (+0.06% 馃敽)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.6 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.61 KB (0%)
@sentry/browser - Webpack (gzipped) 22.78 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 79.03 KB (+0.04% 馃敽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 70.37 KB (+0.03% 馃敽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 36.05 KB (+0.07% 馃敽)
@sentry/browser - ES6 CDN Bundle (gzipped) 25.28 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 221.48 KB (+0.03% 馃敽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 109.08 KB (+0.05% 馃敽)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 75.81 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 39.33 KB (+0.06% 馃敽)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 72.27 KB (+0.03% 馃敽)
@sentry/react - Webpack (gzipped) 22.81 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 90.02 KB (+0.02% 馃敽)
@sentry/nextjs Client - Webpack (gzipped) 54.15 KB (+0.03% 馃敽)
@sentry-internal/feedback - Webpack (gzipped) 17.34 KB (0%)

@lforst lforst merged commit c7ced68 into v7 May 7, 2024
67 checks passed
@lforst lforst deleted the fn/backport-reactrouter-v5 branch May 7, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants