-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(feedback): Simplify feedback function params #11957
Conversation
…ass options around more often
--dialog-inset: auto var(--page-margin) var(--page-margin) auto; | ||
--dialog-padding: 24px; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these and a bunch of stuff above are in Dialog.css.ts now, along with all the :host { ... }
stuff to wrap it.
size-limit report 📦
|
} | ||
|
||
export function DialogHeader({ formTitle, showBranding }: Props): VNode { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
l: i kind of like having the specific props, esp for this component where it only needs 2 of the options
We can simplify the function params and only pass options around most of the time. I also moved some dialog specific css variables into dialog.css.ts so they can be async loaded, which depends on the options config. Before submitting a pull request, please take a look at our [Contributing](https://github.com/getsentry/sentry-javascript/blob/master/CONTRIBUTING.md) guidelines and verify: - [ ] If you've added code that should be tested, please add tests. - [ ] Ensure your code lints and the test suite passes (`yarn lint`) & (`yarn test`).
We can simplify the function params and only pass options around most of the time.
I also moved some dialog specific css variables into dialog.css.ts so they can be async loaded, which depends on the options config.
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint
) & (yarn test
).