fix(node): Ensure execArgv are not sent to worker threads
#11963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HazAT
approved these changes
May 10, 2024
s1gr1d
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11956
--requireand--importinject the code into EVERY child thread and process by default. This means the SDK was injected and started in the worker threads we use for ANR and LocalVariablesAsync and when the SDK starts in those threads, more worker threads are created!There is a warning about this here:
https://nodejs.org/api/worker_threads.html#launching-worker-threads-from-preload-scripts
Setting
execArgv: []stops the SDK from being run in our worker threads.