Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(replay/v7): Fix user activity not being updated in start() #12003

Merged
merged 3 commits into from
May 14, 2024

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented May 13, 2024

Replays will fail to start recording when using start() specifically
when manually recording and after the user has been idle for a long
period of time. We need to reset the user activity state when we call
start(), otherwise the session will be [incorrectly] considered to be
idle and unable to send any replay events.

Replays will fail to start recording when using `start()` specifically
when manually recording and after the user has been idle for a long
period of time. We need to reset the user activity state when we call
`start()`, otherwise the session will be [incorrectly] considered to be
idle and unable to send any replay events.

Closes #11983
@billyvg billyvg changed the base branch from develop to v7 May 13, 2024 14:53
@billyvg billyvg changed the title build(profiling-node): make sure debug build plugin is used (#10534) build(profiling-node): make sure debug build plugin is used May 13, 2024
@billyvg billyvg changed the title build(profiling-node): make sure debug build plugin is used fix(replay/v7): Fix user activity not being updated in start() May 13, 2024
@billyvg billyvg marked this pull request as ready for review May 13, 2024 18:22
@billyvg billyvg closed this May 13, 2024
@billyvg billyvg reopened this May 13, 2024
@billyvg billyvg requested a review from mydea May 13, 2024 18:23
@billyvg billyvg merged commit 3ae4f45 into v7 May 14, 2024
89 checks passed
@billyvg billyvg deleted the fix-replay-start-reset-user-activity-v7 branch May 14, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@sentry/profiling-node: ReferenceError: __DEBUG_BUILD__ is not defined
2 participants