Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(core): Steamline parseSampleRate utility function #12024

Merged
merged 1 commit into from
May 14, 2024

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented May 14, 2024

Just noticed that there's not really a reason to have the two separate warnings. Let's save some bytes.
(we have tests covering this change)

@Lms24 Lms24 requested review from a team, s1gr1d and andreiborza and removed request for a team May 14, 2024 12:08
Copy link
Member

@andreiborza andreiborza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser 21.63 KB (-0.07% 🔽)
@sentry/browser (incl. Tracing) 32.68 KB (-0.03% 🔽)
@sentry/browser (incl. Tracing, Replay) 68.02 KB (-0.02% 🔽)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 61.42 KB (-0.02% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas) 72.06 KB (-0.02% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback) 84.07 KB (-0.02% 🔽)
@sentry/browser (incl. Feedback) 37.56 KB (-0.04% 🔽)
@sentry/browser (incl. sendFeedback) 26.19 KB (-0.05% 🔽)
@sentry/browser (incl. FeedbackAsync) 30.56 KB (-0.05% 🔽)
@sentry/react 24.32 KB (-0.05% 🔽)
@sentry/react (incl. Tracing) 35.64 KB (-0.04% 🔽)
@sentry/vue 25.47 KB (-0.04% 🔽)
@sentry/vue (incl. Tracing) 34.47 KB (-0.03% 🔽)
@sentry/svelte 21.76 KB (-0.06% 🔽)
CDN Bundle 24.13 KB (0%)
CDN Bundle (incl. Tracing) 34.06 KB (0%)
CDN Bundle (incl. Tracing, Replay) 67.73 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) 72.71 KB (0%)
CDN Bundle - uncompressed 70.98 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 101.02 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 210.64 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 222.94 KB (0%)
@sentry/nextjs (client) 34.87 KB (-0.03% 🔽)
@sentry/sveltekit (client) 33.24 KB (-0.04% 🔽)
@sentry/node 147.41 KB (-0.01% 🔽)

@Lms24 Lms24 enabled auto-merge (squash) May 14, 2024 12:13
@Lms24 Lms24 merged commit 012b2c4 into develop May 14, 2024
98 checks passed
@Lms24 Lms24 deleted the lms/ref-core-streamline-parseSampleRate branch May 14, 2024 12:44
andreiborza pushed a commit that referenced this pull request May 16, 2024
Just noticed that there's not really a reason to have the two separate
warnings. Let's save some bytes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants