Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of non-public Vue.util breaks type-checking #2633

Closed
4 of 9 tasks
robinchow opened this issue Jun 3, 2020 · 7 comments · Fixed by #2634
Closed
4 of 9 tasks

Use of non-public Vue.util breaks type-checking #2633

robinchow opened this issue Jun 3, 2020 · 7 comments · Fixed by #2634

Comments

@robinchow
Copy link

Package + Version

  • @sentry/browser
  • @sentry/node
  • raven-js
  • raven-node (raven for node)
  • other: @sentry/integrations

Version:

5.16.0

Description

The interface declaration in vue.d.ts requires Vue.util, but this is not publicly exposed by Vue as declared in this comment - https://github.com/vuejs/vue/blob/fb589e6f9bc7db56a508f8f610ce321377bf0a6f/dist/vue.js#L5392, and also that Vue's types declarations do not contain util - https://github.com/vuejs/vue/blob/dev/types/vue.d.ts.

This is causing type-checking to return Property 'util' is missing in type 'VueConstructor' but required in type 'VueInstance' and breaks the build.

@bobvandevijver
Copy link

This is something that also affects us at the moment. Workaround for now is to add a // @ts-ignore for the time being.

@kamilogorek
Copy link
Contributor

Thanks for letting us know! Fixed in #2634
Also, changed config to be non-optional, as this is how it is in the original Vue types as well.
Cheers!

@omeryousaf
Copy link

@kamilogorek when is this fix expected to be released ?

@kamilogorek
Copy link
Contributor

Just merged it. We should cut the next release on Monday afternoon :)

@kamilogorek
Copy link
Contributor

Fixed in 5.17.0. Cheers!

@xin-
Copy link

xin- commented Jun 23, 2020

image
image

@kamilogorek
Copy link
Contributor

@xin- this is broken because vue-apollo-model is overriding original Vue types - https://github.com/skyline0705/vue-apollo-model/blob/739436a8b8410774236149db29deef1fa0bac623/src/types.ts#L62-L77
It should be fixed there, as Vue.utils is not the part of publicly exposed API see - https://github.com/vuejs/vue/blob/0baa129d4cad44cf1847b0eaf07e95d4c71ab494/src/core/global-api/index.js#L34-L42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants