Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Change Vue interface to be inline with the original types #2634

Merged
merged 3 commits into from Jun 5, 2020
Merged

fix: Change Vue interface to be inline with the original types #2634

merged 3 commits into from Jun 5, 2020

Conversation

kamilogorek
Copy link
Contributor

Fixes #2633

@kamilogorek kamilogorek mentioned this pull request Jun 3, 2020
Closed
9 tasks
@getsentry-bot
Copy link
Contributor

getsentry-bot commented Jun 3, 2020 •
edited

Warnings
⚠️ Please add a changelog entry for your changes.
Messages
📖

@sentry/browser bundle gzip'ed minified size: (ES5: 17.0146 kB) (ES6: 16.0615 kB)
📖 ✅ TSLint passed

Generated by 🚫 dangerJS against ec6bce6

@kamilogorek kamilogorek merged commit fc53353 into master Jun 5, 2020
@kamilogorek kamilogorek deleted the vue-types branch June 5, 2020 13:19
@yotamofek
Copy link

Any chance to have this fix released as a patch version?
Thanks for the hard work!

@kamilogorek
Copy link
Contributor Author

@yotamofek done in 5.17.0.

@yotamofek
Copy link

@kamilogorek Amazing, and very much appreciated. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use of non-public Vue.util breaks type-checking
4 participants
@kamilogorek @getsentry-bot @yotamofek @HazAT