Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hub.startTransaction take 2 #2644

Merged
merged 3 commits into from Jun 8, 2020
Merged

Conversation

rhcarvalho
Copy link
Contributor

Follow up on #2626.

Documentation updates and some refactorings.

@getsentry-bot
Copy link
Contributor

getsentry-bot commented Jun 4, 2020

Warnings
⚠️ Please add a changelog entry for your changes.
Messages
📖

@sentry/browser bundle gzip'ed minified size: (ES5: 17.0137 kB) (ES6: 16.0615 kB)

📖 ✅ TSLint passed

Generated by 🚫 dangerJS against 9eb304b

Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good changes 👍

packages/minimal/src/index.ts Outdated Show resolved Hide resolved
@rhcarvalho rhcarvalho force-pushed the rhcarvalho/start-transaction-on-hub branch from 2f76772 to 5f40460 Compare June 5, 2020 13:52
@rhcarvalho rhcarvalho requested a review from HazAT June 5, 2020 15:29
@rhcarvalho
Copy link
Contributor Author

Ignoring BrowserStack -- https://travis-ci.com/github/getsentry/sentry-javascript/jobs/344138082
Run for ~2h, then looks like some timeouts led to failure.

@rhcarvalho rhcarvalho merged commit 5b6ea3d into master Jun 8, 2020
@rhcarvalho rhcarvalho deleted the rhcarvalho/start-transaction-on-hub branch June 8, 2020 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants