Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Call bindClient in the hub #2665

Merged
merged 6 commits into from Jun 10, 2020
Merged

fix: Call bindClient in the hub #2665

merged 6 commits into from Jun 10, 2020

Conversation

HazAT
Copy link
Member

@HazAT HazAT commented Jun 10, 2020 •
edited

We should call bindClient to make sure we call setupIntegrations when we bind a client to the hub.
Ref getsentry/sentry-docs#1689

Fixes #2541
Fixes #2606

@HazAT HazAT requested a review from kamilogorek as a code owner June 10, 2020 12:22
@HazAT HazAT self-assigned this Jun 10, 2020
@HazAT HazAT mentioned this pull request Jun 10, 2020
Closed
@getsentry-bot
Copy link
Contributor

getsentry-bot commented Jun 10, 2020 •
edited

Messages
📖

@sentry/browser bundle gzip'ed minified size: (ES5: 17.083 kB) (ES6: 16.1533 kB)
📖 ✅ TSLint passed

Generated by 🚫 dangerJS against b30fd02

@kamilogorek kamilogorek self-requested a review June 10, 2020 12:31
@kamilogorek kamilogorek merged commit e8a37d2 into master Jun 10, 2020
@kamilogorek kamilogorek deleted the fix/bindclient branch June 10, 2020 14:43
@kamilogorek kamilogorek mentioned this pull request Jun 17, 2020
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilogorek kamilogorek kamilogorek approved these changes

Assignees

@HazAT HazAT

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@HazAT @getsentry-bot @kamilogorek