Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot find name 'Location' in beforeNavigate option #2696

Closed
3 of 9 tasks
zeldaleung opened this issue Jun 24, 2020 · 0 comments · Fixed by #2700
Closed
3 of 9 tasks

Cannot find name 'Location' in beforeNavigate option #2696

zeldaleung opened this issue Jun 24, 2020 · 0 comments · Fixed by #2700

Comments

@zeldaleung
Copy link

Package + Version

  • @sentry/browser
  • @sentry/node
  • raven-js
  • raven-node (raven for node)
  • other: @sentry/apm

Version:

5.18.0

Description

No issues building with the previous version (5.17.0), but following an upgrade to 5.18.0, the following error message is received on build:

../node_modules/@sentry/apm/dist/integrations/tracing.d.ts:99:30 - error TS2304: Cannot find name 'Location'.
99     beforeNavigate(location: Location): string;

Tried adding dom typings to compilerOptions which allowed the package to build but you really shouldn't need to add dom typings for a node application :(

Note: seems related to #2691

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants