Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tracing): Add manual Location typing #2700

Merged
merged 2 commits into from Jun 29, 2020
Merged

Conversation

AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Jun 26, 2020

Fixes #2696

We shouldn't make people pull in dom typings when they install @sentry/apm. This fixes that.

@AbhiPrasad AbhiPrasad requested a review from HazAT June 26, 2020 15:52
@AbhiPrasad AbhiPrasad marked this pull request as ready for review June 26, 2020 15:52
@getsentry-bot
Copy link
Contributor

Messages
📖

@sentry/browser bundle gzip'ed minified size: (ES5: 17.1387 kB) (ES6: 16.2529 kB)

📖 ✅ TSLint passed

Generated by 🚫 dangerJS against ab5ed1f

@AbhiPrasad AbhiPrasad merged commit de1b2c9 into master Jun 29, 2020
@AbhiPrasad AbhiPrasad deleted the abhi/fix/location-typing branch June 29, 2020 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot find name 'Location' in beforeNavigate option
3 participants