feat(react): Expose eventId on React ErrorBoundary #2704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tirzono
commented
Jun 29, 2020
| setError(false); | ||
| if (props.onReset) { | ||
| props.onReset(err, stack); | ||
| props.onReset(...args); |
There was a problem hiding this comment.
Make sure we pass all the arguments, instead of having to edit this all the time when onReset changes.
AbhiPrasad
requested changes
Jun 29, 2020
Tirzono
force-pushed
the
react-error-boundary
branch
from
9985eaa
to
378ec5f
Compare
|
Thank you for your quick review. My bad, I added a changelog entry now. |
AbhiPrasad
approved these changes
Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes
eventIdon theErrorBoundarycomponent in React. This allows using it in thefallbackcomponent, as an alternative to the dialog (users can report errors with a certain event ID allowing easier look up of the error).