Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[tracing]: fetch headers #2712

Merged
merged 2 commits into from Jul 1, 2020
Merged

fix[tracing]: fetch headers #2712

merged 2 commits into from Jul 1, 2020

Conversation

HazAT
Copy link
Member

@HazAT HazAT commented Jul 1, 2020

Fixes #2685

The cases I tested

  await fetch('/?1', { headers: {'content-type': 'application/json'} });
  await fetch('/?2', { headers: new Headers({ 'content-type': 'application/json' }) });
  await fetch('/?3', { headers: [['content-type', 'application/json']] });
  await fetch('/?4');

@AbhiPrasad We need to add tests for this in @sentry/tracing

@HazAT HazAT requested a review from kamilogorek as a code owner July 1, 2020 12:34
@HazAT HazAT self-assigned this Jul 1, 2020
@getsentry-bot
Copy link
Contributor

getsentry-bot commented Jul 1, 2020

Messages
📖

@sentry/browser bundle gzip'ed minified size: (ES5: 17.1387 kB) (ES6: 16.2529 kB)

📖 ✅ TSLint passed

Generated by 🚫 dangerJS against b79db3a

@HazAT HazAT merged commit 3aba85e into master Jul 1, 2020
@HazAT HazAT deleted the fix/tracing-fetch branch July 1, 2020 13:26
@Janpot
Copy link

Janpot commented Jul 1, 2020

@HazAT Did you test

await fetch(new Request('/?1', { headers: {'content-type': 'application/json'} }));

?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Headers handling in @sentry/apm breaks fetch
4 participants