Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make it also work if someone passes request obj #2713

Merged
merged 1 commit into from Jul 1, 2020

Conversation

HazAT
Copy link
Member

@HazAT HazAT commented Jul 1, 2020

Followup #2711

Tested cases

  await fetch('/?1', { headers: {'content-type': 'application/json'} });
  await fetch(new Request('/?1.1', { headers: {'content-type': 'application/json'} }));
  await fetch('/?2', { headers: new Headers({ 'content-type': 'application/json' }) });
  await fetch(new Request('/?2.1', { headers: new Headers({ 'content-type': 'application/json' }) }));
  await fetch('/?3', { headers: [['content-type', 'application/json']] });
  await fetch(new Request('/?3.1', { headers: [['content-type', 'application/json']] }));
  await fetch('/?4');
  await fetch(new Request('/?4.1'));

cc @Janpot

@HazAT HazAT requested a review from kamilogorek as a code owner July 1, 2020 14:04
@HazAT HazAT self-assigned this Jul 1, 2020
@getsentry-bot
Copy link
Contributor

Warnings
⚠️ Please add a changelog entry for your changes.
Messages
📖

@sentry/browser bundle gzip'ed minified size: (ES5: 17.1387 kB) (ES6: 16.2529 kB)

📖 ✅ TSLint passed

Generated by 🚫 dangerJS against c5c5e30

@HazAT HazAT merged commit b210907 into master Jul 1, 2020
@HazAT HazAT deleted the tracing/fetch-request branch July 1, 2020 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants