Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot find name 'DOMStringList' in Location #2715

Closed
4 of 9 tasks
zeldaleung opened this issue Jul 2, 2020 · 1 comment
Closed
4 of 9 tasks

Cannot find name 'DOMStringList' in Location #2715

zeldaleung opened this issue Jul 2, 2020 · 1 comment

Comments

@zeldaleung
Copy link

zeldaleung commented Jul 2, 2020

Package + Version

  • @sentry/browser
  • @sentry/node
  • raven-js
  • raven-node (raven for node)
  • other: @sentry/apm

Version:

5.19.0

Description

No issues building with version 5.17.0, but following an upgrade to 5.19.0, the following error message is received on build:

../node_modules/@sentry/apm/dist/integrations/types.d.ts:12:31 - error TS2304: Cannot find name 'DOMStringList'.
12     readonly ancestorOrigins: DOMStringList;

Tried adding dom typings to compilerOptions which allowed the package to build -- is your build process automatically including dom for its node builds or something like that? Users really shouldn't need to add dom typings for a node application -_-

@AbhiPrasad
Copy link
Member

Fixed with #2718.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants