fix: Correctly remove all event listeners #2725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
approved these changes
Jul 7, 2020
| @@ -176,9 +176,11 @@ export class TryCatch implements Integration { | |||
| ): () => void { | |||
| let callback = (fn as any) as WrappedFunction; | |||
| try { | |||
| callback = callback && (callback.__sentry_wrapped__ || callback); | |||
| if (callback && callback.__sentry__) { | |||
| original.call(this, eventName, callback.__sentry_original__, options); | |||
There was a problem hiding this comment.
Ah so we have to call remove event listener twice. Makes sense.
Also I would appreciate a comment on why this is happening.
kamilogorek
force-pushed
the
remove-all-listeners
branch
from
9a68a35
to
34896ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2724