fix: Make APM optional in gatsby package #2752
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has two changes after I did some testing with gatsby (https://github.com/getsentry/develop)
fix: Make APM optional in gatsby package
If a user has
@sentry/apm
or@sentry/tracing
, we will use it, otherwise just fallback to normal.ref: Use idleTimout if no activities occur in idle transaction
If idleTransaction does not get any activities pushed in the
idleTimeout
specified we finish the transaction (it most likely points to a simple page with no requests going to happen).We do this by setting a timeout on idle transaction creation. The moment we push an activity, we cancel this timeout and instead rely on the activity system to end the transaction. This is behaviour that was in
@sentry/apm
where it would fake push and pop an activity when creating an idle transaction.