Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Use inline types to avoid redux dependency #2768

Merged
merged 3 commits into from Jul 24, 2020
Merged

Conversation

jennmueng
Copy link
Member

Defines the Redux types used for the enhancer inline in the file so we wouldn't need a Redux dependency.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 23, 2020

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 17.65 KB (-0.01% 🔽)
@sentry/browser - Webpack 18.42 KB (0%)
@sentry/react - Webpack 18.42 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 22.64 KB (0%)

@kamilogorek
Copy link
Contributor

Fingers crossed for these not changing anytime in the future 😬

@getsentry-bot
Copy link
Contributor

getsentry-bot commented Jul 23, 2020

Messages
📖

@sentry/browser bundle gzip'ed minified size: (ES5: 17.248 kB) (ES6: 16.3652 kB)

📖 ✅ TSLint passed

Generated by 🚫 dangerJS against b0b8ab6

@jennmueng jennmueng force-pushed the redux-inline-types branch 2 times, most recently from 1ac4eff to e3a7601 Compare July 24, 2020 14:15
@jennmueng jennmueng merged commit 2fc1568 into master Jul 24, 2020
@jennmueng jennmueng deleted the redux-inline-types branch July 24, 2020 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants