Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Make sure that DSN is always passed to report dialog #2770

Merged
merged 1 commit into from Jul 23, 2020
Merged

fix: Make sure that DSN is always passed to report dialog #2770

merged 1 commit into from Jul 23, 2020

Conversation

kamilogorek
Copy link
Contributor

Fixes #2767

@kamilogorek kamilogorek requested a review from HazAT July 23, 2020 10:58
HazAT
HazAT approved these changes Jul 23, 2020
View reviewed changes
packages/browser/src/helpers.ts Outdated Show resolved Hide resolved
@getsentry-bot
Copy link
Contributor

getsentry-bot commented Jul 23, 2020 •
edited

Warnings
⚠️ Please add a changelog entry for your changes.
Messages
📖

@sentry/browser bundle gzip'ed minified size: (ES5: 17.248 kB) (ES6: 16.3652 kB)
📖 ✅ TSLint passed

Generated by 🚫 dangerJS against 0b9a266

@getsentry getsentry deleted a comment from github-actions bot Jul 23, 2020
@github-actions
Copy link
Contributor

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 17.65 KB (+0.07% 🔺)
@sentry/browser - Webpack 18.42 KB (+0.16% 🔺)
@sentry/react - Webpack 18.42 KB (+0.16% 🔺)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 22.57 KB (+0.02% 🔺)

@kamilogorek kamilogorek merged commit b24387b into master Jul 23, 2020
@kamilogorek kamilogorek deleted the fix-report-dialog branch July 23, 2020 11:28
@AbhiPrasad AbhiPrasad mentioned this pull request Jul 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HazAT HazAT HazAT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sentry logs additionall error
3 participants
@kamilogorek @getsentry-bot @HazAT