New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sentry no longer uses route parameter names for transactions #2967
Comments
Not entirely related in the end, but since this is how we came to notice the issue - I will drop this here as well. sentry-javascript/packages/node/src/handlers.ts Lines 38 to 39 in 7c14283
It seems the performance tracing has never used As it stands, the performance tracing treats every url parameter value as a unique transaction: Perhaps the solution to "unify" things as described in the comment in the source above is to call sentry-javascript/packages/node/src/handlers.ts Lines 65 to 66 in 7c14283
Like: transaction.setName(extractTransaction(req)); (and the needed changes to pass an options object to the |
As a workaround, you can change the transaction name before sending it to Sentry by changing
This is also mentioned under Grouping Transactions |
I don't think this was solved in the last version after #3048 got merged. For us it still logs the full URL in version 5.27.4, putting a log in On errors, the transaction is logged with the route path as the transaction name because that middleware comes after the router. |
@BerndSchrooten will be fixed in #3064 |
Package + Version
@sentry/browser
@sentry/node
raven-js
raven-node
(raven for node)Version:
Description
Since #2714 sentry no longer uses
req.route.path
for transaction names, which causes route paramter values to be logged rather than route parameter nameswget http://localhost:3000/sub/throw-new-error/my-error-type
Transaction as reported using
@sentry/node@5.18.1
:GET|/throw-new-error/:example
Transaction as reported using
@sentry/node@5.19.0
(or higher):GET /sub/throw-new-error/my-error-type
The text was updated successfully, but these errors were encountered: