Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(ci): Remove TravisCI #3149

Merged
merged 14 commits into from Jan 8, 2021
Merged

build(ci): Remove TravisCI #3149

merged 14 commits into from Jan 8, 2021

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Jan 4, 2021

Travis sprung some surprise billing changes on us, so we are now prioritizing removing TravisCI completely.

Travis sprung some surprise billing changes on us, so we are now prioritizing removing TravisCI completely.
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2021

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 19.97 KB (-0.01% 🔽)
@sentry/browser - Webpack 20.8 KB (0%)
@sentry/react - Webpack 20.8 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 27.12 KB (-0.01% 🔽)

@billyvg
Copy link
Member Author

billyvg commented Jan 5, 2021

cc @HazAT @kamilogorek

Some questions:

  • is scripts/test.sh only used in CI, or is it used locally?
  • the node version matrix was only run on pushes (not PRs), is that intentional? Should we remove the build and test jobs from the Build & Test workflow?
  • there's a big discrepancy in run times for GHA vs Travis, are the GHA tests running everything (the logs are kind of hard to parse for me)
    image vs
    image

Anything else that I'm missing?

@billyvg billyvg self-assigned this Jan 5, 2021
@@ -10,6 +10,7 @@ jobs:
job_build:
name: Build
runs-on: ubuntu-latest
timeout-minutes: 15
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added timeouts to all tests as a run away job can eat up our capacity.

@@ -23,7 +23,7 @@ module.exports = {
bs_android_6: {
base: "BrowserStack",
browser: "Android Browser",
device: "Samsung Galaxy Note 4",
device: "Google Nexus 6",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@lobsterkatie lobsterkatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@billyvg
Copy link
Member Author

billyvg commented Jan 6, 2021

Possible gains to be had with lerna concurrency? #3153

@billyvg billyvg marked this pull request as ready for review January 7, 2021 20:03
@billyvg billyvg changed the title build(ci): Remove TravisCI build(ci): Add node version matrix to GHA tests Jan 7, 2021
@billyvg billyvg changed the title build(ci): Add node version matrix to GHA tests build(ci): Remove TravisCI Jan 7, 2021
@lobsterkatie
Copy link
Member

Possible gains to be had with lerna concurrency? #3153

Small ones, yes, but I'm not sure it'll make much of a difference, sadly. If you look at the final two commits in that PR, one with concurrency and one without, and you compare test times, you do get a small savings - around 2 min for the higher versions of node and around 1 min for the lower versions. I actually had my local repo set up to test concurrently for a while. Then I had to change it back for some reason (I forget) and I haven't gotten around to putting it back because the savings isn't that significant.

In any case, unless you feel strongly, let's get this merged and worry about that separately. I was just looking at the package.json commands and there are a few other changes which perhaps could be made also... not to mention which, tooling is going to be reevaluated for the next major release (which should hopefully be soon™), so it may turn out to be a moot point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants