Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix esbuild warning dynamic/indirect calls to require #3164

Merged
merged 3 commits into from Jan 12, 2021
Merged

Fix esbuild warning dynamic/indirect calls to require #3164

merged 3 commits into from Jan 12, 2021

Conversation

doktor500
Copy link
Contributor

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests (Refactor that doesn't change behaviour)
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

Given a project that uses esbuild as a build tool, this warning is prompt when the @sentry/node dependency is added to the project, This PR removes the warning.

Compiling with esbuild...
 > node_modules/@sentry/node/dist/integrations/modules.js: warning: Indirect calls to "require" will not be bundled (surround with a try/catch to silence this warning)
    9 │     var paths = require.cache ? Object.keys(require.cache) : [];~~~~~~~

@doktor500 doktor500 changed the title Fix esbuild warning dynamic require Fix esbuild warning dynamic/indirect calls to require Jan 11, 2021
@kamilogorek kamilogorek merged commit 80aca67 into getsentry:master Jan 12, 2021
@kamilogorek
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants