Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(react): Make _mountSpan protected in the profiler for RN to access #3904

Merged
merged 2 commits into from Aug 23, 2021
Merged

feat(react): Make _mountSpan protected in the profiler for RN to access #3904

merged 2 commits into from Aug 23, 2021

Conversation

jennmueng
Copy link
Member

@jennmueng jennmueng commented Aug 18, 2021 •
edited

The React Native SDK would extend the Profiler into ReactNativeProfiler and would need to access _mountSpan in getsentry/sentry-react-native#1728. So this PR makes it protected instead of private.

--

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

@jennmueng jennmueng requested a review from a team August 18, 2021 14:14
@jennmueng jennmueng self-assigned this Aug 18, 2021
@jennmueng jennmueng requested review from rhcarvalho and lobsterkatie and removed request for a team August 18, 2021 14:14
@jennmueng jennmueng added this to Waiting for Review in Mobile Platform Team Archived Aug 18, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 18, 2021 •
edited

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 21.57 KB (-0.01% 🔽)
@sentry/browser - Webpack 22.57 KB (0%)
@sentry/react - Webpack 22.6 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 29 KB (-0.01% 🔽)

@AbhiPrasad AbhiPrasad changed the title feat: Make _mountSpan protected in the profiler for RN to access feat(react): Make _mountSpan protected in the profiler for RN to access Aug 18, 2021
@jennmueng
Copy link
Member Author

@AbhiPrasad Please merge this for me when ready.

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) August 23, 2021 18:39
@AbhiPrasad AbhiPrasad merged commit 36ee3d6 into master Aug 23, 2021
@AbhiPrasad AbhiPrasad deleted the jenn/mount-span-access branch August 23, 2021 18:50
Mobile Platform Team Archived automation moved this from Waiting for Review to Done Aug 23, 2021
@jennmueng jennmueng mentioned this pull request Aug 31, 2021
Merged
8 tasks
jennmueng added a commit to getsentry/sentry-react-native that referenced this pull request Aug 31, 2021
@jennmueng
build(js): Bump sentry-javascript dependencies to 6.12.0 (#1750)
304fbf6 
Uses the latest GA sentry-javascript version that includes getsentry/sentry-javascript#3904
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@rhcarvalho rhcarvalho Awaiting requested review from rhcarvalho

@lobsterkatie lobsterkatie Awaiting requested review from lobsterkatie

@kamilogorek kamilogorek Awaiting requested review from kamilogorek

Assignees

@jennmueng jennmueng

Labels
None yet
Projects
No open projects
Mobile Platform Team Archived
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jennmueng @AbhiPrasad