Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run loop deprecations at @sentry/ember #3911

Closed
4 of 9 tasks
vlascik opened this issue Aug 21, 2021 · 4 comments
Closed
4 of 9 tasks

Run loop deprecations at @sentry/ember #3911

vlascik opened this issue Aug 21, 2021 · 4 comments
Assignees

Comments

@vlascik
Copy link

vlascik commented Aug 21, 2021

Package + Version

  • @sentry/browser
  • @sentry/node
  • raven-js
  • raven-node (raven for node)
  • other: @sentry/ember

Version:

6.11.0

Description

Usage of run import e.g. in


which is then used to call runloop functions like run.scheduleOnce, is deprecated as of ember-source 3.27 (deprecated-run-loop-and-computed-dot-access, functions should be imported directly instead).

There may be more places this pattern is used, too.

@nelstrom
Copy link

nelstrom commented Sep 7, 2021

Looks as though this issue has been addressed by #3915

@k-fish
Copy link
Member

k-fish commented Sep 7, 2021

Ah, yeah, sorry, they got caught in the 4.0 forward-compatible work, I forgot to circle back to update this issue. Thanks for reporting 👍 .

@k-fish k-fish closed this as completed Sep 7, 2021
@Turbo87
Copy link
Contributor

Turbo87 commented Nov 11, 2021

Bildschirmfoto 2021-11-11 um 10 27 35

These deprecation warnings are still being shown, because we're still accessing run.backburner in the getBackburner() function.

@mileszim
Copy link

mileszim commented Dec 9, 2021

@k-fish Using the latest and I am still seeing this. Code is still here

if (run.backburner) {
return run.backburner;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants