misc(browser): Log when event is dropped by Dedupe integration #3943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
approved these changes
Aug 31, 2021
AbhiPrasad
reviewed
Aug 31, 2021
| @@ -27,6 +28,7 @@ export class Dedupe implements Integration { | |||
| // Juuust in case something goes wrong | |||
| try { | |||
| if (self._shouldDropEvent(currentEvent, self._previousEvent)) { | |||
| logger.warn(`Event dropped due to being a duplicate of previously captured event.`); | |||
There was a problem hiding this comment.
Wait should we do this with https://github.com/getsentry/sentry-javascript/blob/master/packages/integrations/src/dedupe.ts as well?
size-limit report
|
kamilogorek
force-pushed
the
dedupe-log
branch
from
b68144d
to
69bc67b
Compare
|
Ugh, right, thanks. Updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rel: #3939 (comment)