Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): use apply in console instrumentation #4568

Merged
merged 4 commits into from
Feb 14, 2022
Merged

Conversation

AbhiPrasad
Copy link
Member

Fixes #4558

@AbhiPrasad AbhiPrasad requested review from a team, Lms24 and lobsterkatie and removed request for a team February 14, 2022 18:20
@github-actions
Copy link
Contributor

github-actions bot commented Feb 14, 2022

size-limit report

Path Base Size (2a150ee) Current Size Change
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.65 KB 19.65 KB +0.01% 🔺
@sentry/browser - ES5 CDN Bundle (minified) 63 KB 63 KB +0.01% 🔺
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.32 KB 18.31 KB -0.02% 🔽
@sentry/browser - ES6 CDN Bundle (minified) 56.15 KB 56.15 KB +0.01% 🔺
@sentry/browser - Webpack (gzipped + minified) 22.1 KB 22.1 KB 0%
@sentry/browser - Webpack (minified) 75.86 KB 75.86 KB +0.01% 🔺
@sentry/react - Webpack (gzipped + minified) 22.14 KB 22.14 KB +0.01% 🔺
@sentry/nextjs Client - Webpack (gzipped + minified) 46.26 KB 46.26 KB 0%
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 27.1 KB 27.1 KB 0%

Copy link
Member

@lobsterkatie lobsterkatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work adding the test!

Co-authored-by: Katie Byers <lobsterkatie@gmail.com>
@AbhiPrasad AbhiPrasad enabled auto-merge (squash) February 14, 2022 19:16
Copy link
Member

@lobsterkatie lobsterkatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@AbhiPrasad AbhiPrasad merged commit b46674c into master Feb 14, 2022
@AbhiPrasad AbhiPrasad deleted the abhi-console-fix branch February 14, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sentry 6.17.7 changes logged message from String to Array
2 participants