ref(core): Log normalizeDepth
when normalization is skipped
#4574
+42
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing debugging of #2809. In the most recent example event there, it's clear from the stringifying error's stacktrace that the event is hitting
BaseClient._processEvent
, and we can tell from the line number in that stack trace that it's getting past_prepareEvent
, which is what callsnormalize
.In
_prepareEvent
, the only way for normalization not to run is if thenormalizeDepth
option either isn't a number or is set to a value <= 0. (It's got a default value, so it not being set directly by the user isn't the issue.)sentry-javascript/packages/core/src/baseclient.ts
Lines 377 to 379 in b46674c
In order to better diagnose what the problem might be, this PR adds logging of the
normalizeDepth
value in cases where an event fails to be normalized when it should.