Skip to content

fix(hub): keep hint event id if it's provided #4577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 16, 2022
Merged

fix(hub): keep hint event id if it's provided #4577

merged 3 commits into from
Feb 16, 2022

Conversation

Doodidan
Copy link
Contributor

@Doodidan Doodidan commented Feb 15, 2022

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

Sorry, something went wrong.

Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks for opening a PR! Could you add some tests for your changes?

@Doodidan
Copy link
Contributor Author

@AbhiPrasad Hey there! Sure, I have added some tests for that case. Could you review it please?

@Doodidan Doodidan requested a review from AbhiPrasad February 16, 2022 13:43
@AbhiPrasad AbhiPrasad changed the title Hub: keep hint event id if it's provided fix(hub): keep hint event id if it's provided Feb 16, 2022
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@AbhiPrasad AbhiPrasad merged commit a789ccd into getsentry:master Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants