Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(browser): Only set event.stacktrace if we have 1 or more frames #4614

Merged

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Feb 21, 2022

Fixes #4418

event.stacktrace is deprecated and will likely be moved to exception on the next major release.

However, no frames = no stacktrace will still stand then!

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) February 23, 2022 12:08
@AbhiPrasad AbhiPrasad merged commit 0af57a4 into getsentry:master Feb 23, 2022
@AbhiPrasad AbhiPrasad added this to the Pre 7.0.0 Work milestone Feb 23, 2022
@timfish timfish deleted the event.stacktrace.frames-not-empty branch February 24, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not set stacktrace if there are no frames
2 participants