ref(node): Remove dependency on @sentry/tracing
#4647
Merged
+58
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
requested review from
a team,
Lms24 and
lobsterkatie
and removed request for
a team
size-limit report
|
AbhiPrasad
force-pushed
the
abhi-tracing-to-utils
branch
from
3ad3834 to
503bf89
Compare
AbhiPrasad
force-pushed
the
abhi-tracing-to-utils
branch
from
503bf89 to
5da47a9
Compare
Lms24
approved these changes
Mar 1, 2022
Co-authored-by: Katie Byers <lobsterkatie@gmail.com>
AbhiPrasad
added a commit
that referenced
this pull request
Mar 2, 2022
We would like to remove `@sentry/tracing` as a dependency to `@sentry/node` since it has a massive impact on startup time.
We do this by eliminating the `import { extractTraceparentData, Span } from '@sentry/tracing';` in `packages/node/src/handlers.ts`
We move `extractTraceparentData` into `@sentry/utils` and use `Span` from `@sentry/types` instead of `@sentry/tracing`.
Co-authored-by: Katie Byers <lobsterkatie@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4642
We would like to remove
@sentry/tracingas a dependency to@sentry/nodesince it has a massive impact on startup time.We do this by eliminating the
import { extractTraceparentData, Span } from '@sentry/tracing';inpackages/node/src/handlers.tsWe move
extractTraceparentDatainto@sentry/utilsand useSpanfrom@sentry/typesinstead of@sentry/tracing.Resolves https://getsentry.atlassian.net/browse/WEB-637