Skip to content

ref(node): Fix async stack parsing #4721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 18, 2022
Merged

ref(node): Fix async stack parsing #4721

merged 3 commits into from
Mar 18, 2022
+111 −21

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Mar 15, 2022

Fixes #4692

This fixes a number of issues with node stack parsing:

  • Regex did not cater for async stack frames (introduced node v12)
  • file:// was not being stripped from paths
  • Some anonymous functions were ending up as undefined.<anonymous>

AbhiPrasad
AbhiPrasad approved these changes Mar 15, 2022
View reviewed changes
@timfish timfish requested a review from AbhiPrasad March 15, 2022 21:29
@AbhiPrasad AbhiPrasad merged commit 4eadcaf into getsentry:master Mar 18, 2022
@timfish timfish deleted the fix/node-async-stack-parse branch March 23, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code missing in stack traces using 6.18.1
2 participants
@timfish @AbhiPrasad