ref(build): Add central build directory to packages without CDN bundles (Part 1)
#4854
+127
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
changed the title
prepack.ts to distinguish between packages with/-out bundlesbuild directory to packages without CDN bundles (Part 1)
Lms24
force-pushed
the
lms-build-dir-packages-no-bundles
branch
from
ccc6d4c to
25ff8a6
Compare
AbhiPrasad
reviewed
Apr 5, 2022
explain ignoring of package specific prepack in `.eslintrc.js`
Lms24
force-pushed
the
lms-build-dir-packages-no-bundles
branch
from
cbc50d2 to
0a56148
Compare
size-limit report 📦
|
Lms24
changed the title
build directory to packages without CDN bundles (Part 1)build directory to packages without CDN bundles (Part 1)
AbhiPrasad
reviewed
Apr 6, 2022
AbhiPrasad
approved these changes
Apr 6, 2022
|
Thanks for the review, I added the suggestions |
AbhiPrasad
reviewed
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This PR is the continuation of our ongoing effort of introducing a central
builddirectory in all* our packages. In the last PR (#4838), thebuilddirectory was added to packages with CDN bundles.*some packages will not be adjusted, as their build process differs significantly from our other packages (e.g. Ember, Angular soon).
Changes
This PR is part 1 of adding the
builddirectory to packages without CDN bundles. It is split into two parts to make reviewing easier. It covers the following packages:Additionally, it adjusts
prepack.tsto handle both kinds of packages (with/without CDN bundles) via a CL argument. For the Gatsby SDK, additional actions have to be performed which are only relevant for this package. Therefore,prepack.tsnow supports calling a package-specificprepack.tsfile located in<package>/scripts/prepack.ts.While the tarball structure is identical to the structure in #4838 (except for temporary CDN bundles), the
builddirectory structure is simplified due to the fact that there are no CDN bundles or legacy NPM packages to be added to it. Therefore we can reduce one hierarchy level, resulting in the following structure: