ref(nextjs): Use generic loader to inject global values #6484
Conversation
size-limit report 📦
|
| const { values } = 'getOptions' in this ? this.getOptions() : this.query; | ||
|
|
||
| // Define some global proxy that works on server and on the browser. | ||
| let injectedCode = 'var _sentryCollisionFreeGlobalObject = typeof window === "undefined" ? global : window;\n'; |
There was a problem hiding this comment.
M: Do we need to worry about web workers/self here, do you think? Is there a reason not to just use GLOBAL_OBJ from @sentry/utils?
There was a problem hiding this comment.
I think we don't need to worry about web workers here. The loader is only applied to sentry.server.config.js and sentry.client.config.js and I think we are safe to assume that sentry.client.config.js will not be injected into any web worker contexts. Unless I am missing something.
Considering the above I would just keep it as-is to keep the logic simple.
Had a very similar thought. We probably should at some point - right now it would bloat the logic of the loader a lot. Let's see how many values we'll be injecting first. |
Refactor to add a webpack loader to the Next.js SDK to inject global variables into both the browser and the server-side SDK.
This change is needed for #5571 where we need to put a string on the global scope in the build step to read from during runtime. We have the prefix loader that is able to inject pretty much any code in the SDK - that would have also been an option to use but it seemed a bit overkill for this simple use-case.
This loader will also potentially become useful in the future for planned heartbeat/pulse checks during initialization to check if the SDK has been set up correctly.