Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs): Fix automatic release value discovery #6513

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

lforst
Copy link
Member

@lforst lforst commented Dec 13, 2022

Fixes #6504

In we switched from the Sentry Webpack plugin to using a custom loader to inject the release value into the SDK that either reads from options or from environment variables. We didn't consider that the Webpack Plugin (or rather Sentry CLI) has a mechanism to determine a release value apart from options or environment variables.

This PR in essence reverts #6404 which introduced this bug.

@lforst lforst requested a review from Lms24 December 13, 2022 13:19
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.71 KB (-0.01% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 61.11 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.5 KB (-0.03% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 54.64 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.28 KB (0%)
@sentry/browser - Webpack (minified) 66.33 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.3 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.5 KB (+0.42% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.7 KB (-0.02% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.15 KB (+0.01% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 41.73 KB (-0.01% 🔽)
@sentry/replay - Webpack (gzipped + minified) 38 KB (0%)

@lforst lforst merged commit 81c3a38 into master Dec 13, 2022
@lforst lforst deleted the lforst-fix-automatic-release-value-discovery branch December 13, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release info is not sent in the event payload (7.24.0 breaks it)
2 participants