Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(replay): Do not capture errors originating from rrweb #6521

Merged
merged 1 commit into from
Dec 14, 2022

Conversation

mydea
Copy link
Member

@mydea mydea commented Dec 14, 2022

rrweb can throw hard to pinpoint errors in its internals, e.g. when working with iframes or other hard to control environments.
We want to avoid flooding sentry errors with these, so this PR filters them out based on stracktrace.

Unless using captureExceptions experiment, we want to ignore these errors.

This is probably not 100% bullet proof, and relies on source maps etc. being correct, but I think it should help in a good amount of cases, at least.

Closes #6418

Unless using `captureExceptions` experiment, we want to ignore these errors.
@mydea mydea requested review from billyvg and Lms24 December 14, 2022 09:23
@mydea mydea self-assigned this Dec 14, 2022
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.72 KB (0%)
@sentry/browser - ES5 CDN Bundle (minified) 61.13 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.51 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 54.66 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.28 KB (0%)
@sentry/browser - Webpack (minified) 66.33 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.3 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.5 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.69 KB (+0.02% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.14 KB (0%)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 41.83 KB (+0.33% 🔺)
@sentry/replay - Webpack (gzipped + minified) 38.08 KB (+0.32% 🔺)

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! As discuessed, let's see how this works out and if necessary make adjustments later. I think, having the captureExceptions flag to still enable sending these errors is good for debugging purposes 👍

@mydea mydea merged commit 967dfb1 into master Dec 14, 2022
@mydea mydea deleted the fn/replay-ignore-rrweb-errors branch December 14, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Replay] Ignore all rrweb errors
2 participants