Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(nextjs): Remove instrumentSever #6592

Merged
merged 2 commits into from
Jan 5, 2023
Merged

ref(nextjs): Remove instrumentSever #6592

merged 2 commits into from
Jan 5, 2023

Conversation

lforst
Copy link
Member

@lforst lforst commented Dec 21, 2022 •
edited

Resolves #6642

This PR removes the generic server instrumentation. For more information see #6642

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.78 KB (-0.02% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 61.27 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.56 KB (-0.01% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 54.8 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.34 KB (0%)
@sentry/browser - Webpack (minified) 66.48 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.36 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.58 KB (+0.04% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.76 KB (0%)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.19 KB (-0.02% 🔽)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 42.08 KB (-0.01% 🔽)
@sentry/replay - Webpack (gzipped + minified) 38.13 KB (0%)

@lforst lforst mentioned this pull request Dec 21, 2022
Merged
@lforst lforst marked this pull request as ready for review January 3, 2023 15:17
Lms24
Lms24 approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RIP

@lforst lforst merged commit c65597f into master Jan 5, 2023
@lforst lforst deleted the lforst-remove-instrument-server branch January 5, 2023 14:32
@lforst lforst mentioned this pull request Jan 11, 2023
Closed
3 tasks
@lforst lforst mentioned this pull request Apr 3, 2023
Merged
@shouze shouze mentioned this pull request May 2, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

@mydea mydea Awaiting requested review from mydea

@AbhiPrasad AbhiPrasad Awaiting requested review from AbhiPrasad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Removing generic server instrumentation from @sentry/nextjs
2 participants
@lforst @Lms24