feat(gatsby): Support Gatsby v5 #6635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release notes: https://www.gatsbyjs.com/docs/reference/release-notes/v5.0/ Migration guide: https://www.gatsbyjs.com/docs/reference/release-notes/migrating-from-v4-to-v5/ Resolves #6261
Lms24
requested review from
a team,
mydea,
lforst and
Lms24
and removed request for
a team
|
Hi @rjoonas, thanks for opening this PR! Did you have any chance to test the SDK in v5? I'm curious if you noticed any obvious problems or odd behaviour. |
Tried creating a fresh Gatsby 5 project using |
lforst
approved these changes
Jan 4, 2023
|
Thank you! :) |
|
We just released this change with version |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least the Gatsby v5 release notes mention no changes to the plugin interfaces used here (
gatsby-browser#onClientEntryandgatsby-node#onCreateWebpackConfig).The only instruction for plugin maintainers in the v4 to v5 migration guide is that ”In most cases, you won’t have to do anything to be v5 compatible.”
Resolves #6261.
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).