Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): Add addIntegration method to client #6651

Merged
merged 2 commits into from
Jan 5, 2023
Merged

feat(core): Add addIntegration method to client #6651

merged 2 commits into from
Jan 5, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Jan 4, 2023 •
edited

This can be used to add an integration at runtime.

This is useful e.g. for replay, where we may want to lazy load this (as the payload is quite large).

@mydea mydea requested review from lforst and Lms24 January 4, 2023 10:43
@mydea mydea self-assigned this Jan 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2023 •
edited

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.84 KB (+0.11% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 61.43 KB (+0.15% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.61 KB (+0.09% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 54.98 KB (+0.13% 🔺)
@sentry/browser - Webpack (gzipped + minified) 20.38 KB (+0.11% 🔺)
@sentry/browser - Webpack (minified) 66.62 KB (+0.14% 🔺)
@sentry/react - Webpack (gzipped + minified) 20.41 KB (+0.1% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.65 KB (+0.05% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.81 KB (+0.11% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.25 KB (+0.11% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 42.99 KB (-0.02% 🔽)
@sentry/replay - Webpack (gzipped + minified) 38.24 KB (+0.01% 🔺)

lforst
lforst approved these changes Jan 4, 2023
View reviewed changes
packages/types/src/client.ts Outdated Show resolved Hide resolved
Lms24
Lms24 approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks like bundle size impact is negligible so I'd say let's go for it!

packages/types/src/client.ts Show resolved Hide resolved
@mydea
feat(core): Add addIntegration method to client
db525cf 
This can be used to add an integration at run time.
@mydea
ref: Add todo note
bd399b3
@mydea mydea merged commit 55d708f into master Jan 5, 2023
@mydea mydea deleted the fn/addIntegration branch January 5, 2023 09:01
@shouze shouze mentioned this pull request May 2, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jason-hwang jason-hwang jason-hwang left review comments

@lforst lforst lforst approved these changes

@Lms24 Lms24 Lms24 approved these changes

Assignees

@mydea mydea

Labels
Package: core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mydea @jason-hwang @lforst @Lms24