fix(nextjs): Don't wrap res.json
and res.send
#6674
Merged
+30
−24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6670
By inspiration from axiom we wrapped all response methods in order to flush in a timely manner on AWS lambdas and Vercel. Turns out this is unnecessary because
res.end
is implicitly called byres.send
andres.json
so it is the only one we need to block.Additionally wrapping
send
andjson
caused race conditions when they're called before.end
because we turned them into async functions soend
would sometimes be called before the other methods and prematurely terminatedthe response.This PR removes the wrapping from
res.json
andres.end
to fix the issues outlined above.