fix(react): make wrapCreateBrowserRouter generic

[h3rmanj]

Reduces the Router and RouterState to the minimal internal usage, and makes the wrapper accept a generic which extends the minimal types. This allows for react-router to make changes to their Router types, without breaking our types.

Fixes #6861

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

• If you've added code that should be tested, please add tests.
• Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

[h3rmanj]

So, I tried to make the internal types as minimal as possible, to only include the properties that are used in @sentry/react. Then I made the wrapCreateBrowserRouter accept generic types which extends the minimal types, meaning the type returned should be from the consumers react-router-dom version.

This works fine when I link the package up and try it out in a project. However the test suite fails, which I assume to be because this project uses TypeScript v3, while what I do most likely only works with v4.

Edit:

Nevermind, I think I got it to work after all. I'm not too happy typing things with as x, but it was done before. With typescript v4 the as can be removed entirely, which is what confused me.

[AbhiPrasad]

Thanks! Opened #6865 so we can make sure we catch this before users do.

[h3rmanj]

@AbhiPrasad do note that this changes CreateRouterFunction, so if anyone imports it in their project the type might break for them.

I'll try to add a default to the generic args to fix it.

[onurtemizkan]

Looks good to me! Thanks @h3rmanj.

[AbhiPrasad]

@h3rmanj we'll try and get a release out with this fix early next week!

[h3rmanj]

Sounds good, thanks!