fix(replay): Only call scope.getLastBreadcrumb if available
#6969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-nathani
reviewed
Jan 30, 2023
| @@ -26,6 +26,10 @@ export const handleScopeListener: (replay: ReplayContainer) => (scope: Scope) => | |||
| * An event handler to handle scope changes. | |||
| */ | |||
| export function handleScope(scope: Scope): Breadcrumb | null { | |||
| if (typeof scope.getLastBreadcrumb !== 'function') { | |||
There was a problem hiding this comment.
LGTM. 👍🏼
I wish i would have created this PR before 🤦🏼 🥼
There was a problem hiding this comment.
According to this methods signature, scope is always defined; so no need to guard against it being undefined ;)
Furthermore, this is where we call the function that ends up calling handleScope. As you can see, it is guarded by the scope being defined there:
There was a problem hiding this comment.
awesome sauce... 🆒 . The guarded scope looks good ⚡
There was a problem hiding this comment.
l: I would just do if (scope.getLastBreadcrumb), saves some bytes and should be good enough here!
size-limit report 📦
|
mydea
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope.getLastBreadcrumbwas introduced quite recently for replay and it generally works fine. Just in the few edge cases, where the base SDK version can't be changed or multiple hubs cause conflicts, Replay will crash when the method is not available on the passed scope. This PR letshandleScopeearly-returnnullin case thegetLastBreadcrumbmethod does not exist. This will lead to missing breadcrumbs in the replay but at least it will avoid a crash.closes #6542