Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs): Don't modify require calls in wrapping loader #6979

Merged
merged 4 commits into from
Jan 31, 2023

Conversation

lforst
Copy link
Member

@lforst lforst commented Jan 30, 2023

The wrapping loader in the Next.js SDK seems to have problems with CJS.

Users reported the following issues:

Fixes #6970
Fixes #6943
Fixes #6961

@github-actions
Copy link
Contributor

github-actions bot commented Jan 30, 2023

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.85 KB (-0.02% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 61.55 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.52 KB (-0.01% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 54.85 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.24 KB (0%)
@sentry/browser - Webpack (minified) 66.25 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.27 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.55 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.77 KB (-0.02% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.06 KB (-0.01% 🔽)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 44.15 KB (-0.01% 🔽)
@sentry/replay - Webpack (gzipped + minified) 38.9 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 61.47 KB (-0.01% 🔽)

@lforst lforst self-assigned this Jan 31, 2023
@lforst lforst marked this pull request as ready for review January 31, 2023 10:12
@lforst lforst merged commit acd6d58 into master Jan 31, 2023
@lforst lforst deleted the lforst-fix-cjs-imports branch January 31, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants