Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(replay): Add back deprecated maskInputOptions #6981

Merged
merged 10 commits into from
Feb 1, 2023
Merged

feat(replay): Add back deprecated maskInputOptions #6981

merged 10 commits into from
Feb 1, 2023

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Jan 30, 2023

This was unintentionally removed in #6645 - it is still deprecated and will be removed at a later date.

@billyvg
feat(replay): Add back deprecated maskInputOptions
5d16b6b 
This was unintentionally removed in #6645 - it is still deprecated and will be removed at a later date.
@billyvg
optional
03b3bf9
@github-actions
Copy link
Contributor

github-actions bot commented Jan 30, 2023 •
edited

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.87 KB (-0.01% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 61.57 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.54 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified) 54.88 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.29 KB (0%)
@sentry/browser - Webpack (minified) 66.37 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.31 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.6 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.79 KB (0%)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.08 KB (-0.01% 🔽)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 43.81 KB (-0.8% 🔽)
@sentry/replay - Webpack (gzipped + minified) 38.72 KB (-0.44% 🔽)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 61.4 KB (-0.17% 🔽)

@billyvg billyvg marked this pull request as ready for review February 1, 2023 00:57
@billyvg billyvg requested review from mydea and Lms24 February 1, 2023 00:57
@billyvg @Lms24
Update packages/replay/src/integration.ts
85a39a5 
Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
Lms24
Lms24 previously approved these changes Feb 1, 2023
View reviewed changes
@billyvg billyvg changed the base branch from master to develop February 1, 2023 16:14
@billyvg billyvg dismissed Lms24’s stale review February 1, 2023 16:14

The base branch was changed.

@billyvg billyvg enabled auto-merge (squash) February 1, 2023 16:42
Lms24
Lms24 approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my feedback :)

@billyvg billyvg merged commit c3dd355 into develop Feb 1, 2023
@billyvg billyvg deleted the feat-replay-add-mask-input-options branch February 1, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

@mydea mydea Awaiting requested review from mydea

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@billyvg @Lms24