Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs): Add isomorphic versions of ErrorBoundary, withErrorBoundary and showReportDialog #6987

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

lforst
Copy link
Member

@lforst lforst commented Jan 31, 2023

Trying to enable the app-dir server tests on master gave me a failure that we are importing react specifics on the server which is not allowed on in the app dir.

This PR creates react-less pass-throughs for the server SDK to get rid of this error. This error might actually also appear for some users.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.87 KB (+0.1% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 61.57 KB (+0.05% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.54 KB (+0.12% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 54.88 KB (+0.07% 🔺)
@sentry/browser - Webpack (gzipped + minified) 20.29 KB (+0.24% 🔺)
@sentry/browser - Webpack (minified) 66.37 KB (+0.18% 🔺)
@sentry/react - Webpack (gzipped + minified) 20.31 KB (+0.23% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.6 KB (+0.11% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.79 KB (+0.06% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.08 KB (+0.08% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 44.15 KB (-0.01% 🔽)
@sentry/replay - Webpack (gzipped + minified) 38.9 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 61.5 KB (+0.04% 🔺)

@lforst lforst merged commit 00482d8 into master Jan 31, 2023
@lforst lforst deleted the lforst-no-client-react-sdk-on-server branch January 31, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants