Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(replay): Adjust slow/multi click handling #8380

Merged
merged 3 commits into from Jul 5, 2023
Merged

fix(replay): Adjust slow/multi click handling #8380

merged 3 commits into from Jul 5, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Jun 22, 2023

Implements the changes outlined in #8379

@mydea mydea requested a review from billyvg June 22, 2023 08:27
@mydea mydea self-assigned this Jun 22, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 22, 2023 •
edited

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 21.17 KB (0%)
@sentry/browser - ES5 CDN Bundle (minified) 66.13 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.71 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified) 58.6 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 21.33 KB (0%)
@sentry/browser - Webpack (minified) 69.52 KB (0%)
@sentry/react - Webpack (gzipped + minified) 21.36 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 49.28 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 28.79 KB (-0.01% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 27.03 KB (+0.01% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 49.3 KB (-0.07% 🔽)
@sentry/replay - Webpack (gzipped + minified) 43.02 KB (-0.13% 🔽)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 68.31 KB (-0.07% 🔽)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 61.21 KB (-0.08% 🔽)

@mydea mydea force-pushed the fn/slow-click-multi-click-combo branch from 3f3300e to 4389c5e Compare June 22, 2023 13:52
billyvg
billyvg approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@billyvg billyvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good but let's wait a bit before merging, I'd like to look at our current data before making more tweaks?

@mydea
Copy link
Member Author

mydea commented Jun 28, 2023

Update: I removed previousSessionId from the PR, based on conversations we had about this.

@mydea mydea merged commit 4b98349 into develop Jul 5, 2023
58 checks passed
@mydea mydea deleted the fn/slow-click-multi-click-combo branch July 5, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billyvg billyvg billyvg approved these changes

Assignees

@mydea mydea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mydea @billyvg