Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(tracing): Add origin to spans #8765

Merged
merged 11 commits into from Aug 29, 2023
Merged

ref(tracing): Add origin to spans #8765

merged 11 commits into from Aug 29, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Aug 9, 2023

This adds an origin to all spans, which defaults to manual but is set to something more meaningful for all our auto instrumentation.

I tried to come up with reasonable origin names, I hope it makes sense everywhere 馃槄 Also note that this now uses a new TS feature which seems to be correctly transpiled to TS 3.8, as far as I can tell! 馃帀

Closes #8510

@mydea mydea self-assigned this Aug 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

size-limit report 馃摝

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 75.26 KB (+0.05% 馃敽)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.22 KB (+0.05% 馃敽)
@sentry/browser - Webpack (gzipped) 21.85 KB (+0.02% 馃敽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 69.79 KB (+0.07% 馃敽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 28.24 KB (+0.12% 馃敽)
@sentry/browser - ES6 CDN Bundle (gzipped) 20.18 KB (-0.02% 馃斀)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 220.34 KB (+0.14% 馃敽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 85.17 KB (+0.34% 馃敽)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 59.88 KB (+0.04% 馃敽)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 31.15 KB (+0.14% 馃敽)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 75.28 KB (+0.06% 馃敽)
@sentry/react - Webpack (gzipped) 21.88 KB (+0.02% 馃敽)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 93.09 KB (+0.06% 馃敽)
@sentry/nextjs Client - Webpack (gzipped) 50.8 KB (+0.13% 馃敽)

Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding origin to a transaction does nothing atm right?

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjusted the origins of all packages (mostly navigation and pageload ops)

this.data = spanContext.data || {};
this.instrumenter = spanContext.instrumenter || 'sentry';
this.origin = spanContext.origin || 'manual';

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: (or no action required) we might wanna streamline some of the other assignments here as well but it's ouf of scope for this PR. feel free to ignore

@mydea
Copy link
Member Author

mydea commented Aug 10, 2023

Adding origin to a transaction does nothing atm right?

It's not shown anywhere at least, as far as I can tell!

@mydea mydea merged commit 0fd86bc into develop Aug 29, 2023
78 checks passed
@mydea mydea deleted the fn/trace-origin branch August 29, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send trace origin
4 participants