Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Remove build-specific polyfills #8809

Merged
merged 1 commit into from Aug 14, 2023
Merged

build: Remove build-specific polyfills #8809

merged 1 commit into from Aug 14, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Aug 14, 2023

It seems they do not do anything - at least I compared the complete build ouput for node, core & browser with & without this, and it appeared exactly the same.

Not sure, maybe I missed something, it is not entirely clear to me how/what/when these would be applied etc.

@mydea mydea self-assigned this Aug 14, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 14, 2023

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 75.12 KB (+0.36% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.14 KB (+0.09% 🔺)
@sentry/browser - Webpack (gzipped) 21.81 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 69.73 KB (+0.27% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 28.18 KB (+0.11% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 20.18 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 219.89 KB (+0.38% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 84.78 KB (+0.13% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 59.86 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 31.04 KB (+0.09% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 65.3 KB (+0.39% 🔺)
@sentry/react - Webpack (gzipped) 21.84 KB (-0.01% 🔽)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 92.93 KB (+0.31% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 50.66 KB (+0.1% 🔺)

Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's do it!

not sure why these don't get used anymore either, but if all the tests pass I'm confident.

It _seems_ they do not do anything - at least I compared the complete build ouput for node, core & browser with & without this, and it appeared _exactly_ the same.
@mydea mydea merged commit 448406a into develop Aug 14, 2023
78 checks passed
@mydea mydea deleted the fn/polyfills-rollup branch August 14, 2023 13:54
@bjarn
Copy link

bjarn commented Aug 30, 2023

Hi @mydea / @AbhiPrasad,

Might this be related to these changes?
Screenshot 2023-08-30 at 11 52 40@2x

I just upgraded to 7.65.0 when, during a nextjs build, every page fails due to several resolve errors (not limited to 'fs') all coming from Sentry.
Downgraded to 7.64.0 and all is fine. This was the only PR on the changelog that might make sense to me. But not sure.

If you need any more info, let me know.

@lforst
Copy link
Member

lforst commented Aug 30, 2023

@bjarn this will be fixed in 7.66.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants